design patterns - How could I improve this C++ code -

-

i want suggestion on following pseudo-code. please suggest how improve it, whether or not use design patterns.

 // i'm receiving string containing : id operation arguments data    = read(socket); tokens  = tokenize(data," "); // tokenize string based on spaces if(tokens[0] == "a") {    if(tokens[1] == "some_operation") {       // here goes code some_operation , use remaining tokens arguments function calls    }    else if(tokens[1] == "some_other_operation") {      // here goes code some_other_operation , use remaining tokens    }    ...    else {      // unknown operation    } } else if(tokens[0] == "b") {    if(tokens[1] == "some_operation_for_b") {      // operation b    }    else if(tokens[1] == "yet_another_operation") {      // yet_another_operation b    }    ...    else {      // unknown operation    }  }

i hope point . thing have large number of id's , each has it's own operations , , think it's kinda ugly have 10 screens of code containing lot of if's , else if's.

have class each id implements common interface. strategy pattern iirc.

so you'd call (pseudo)code like:

strategyfactory.getstrategy(tokens[0]).parse(tokens[1..n])


Comments

Post a Comment

Popular posts from this blog

c++ - How do I get a multi line tooltip in MFC -

-
right now, have tool tip pops when hover on edit box. problem tool tip contains multiple error messages , in 1 long line. need have each error message on own line. error messages contained in cstring new line seperating them. my existing code below. bool ontooltiptext(uint, nmhdr* pnmhdr, lresult* presult) { assert(pnmhdr->code == ttn_needtexta || pnmhdr->code == ttn_needtextw); // need handle both ansi , unicode versions of message tooltiptexta* pttta = (tooltiptexta*)pnmhdr; tooltiptextw* ptttw = (tooltiptextw*)pnmhdr; // tchar szfulltext[256]; cstring strtiptext=_t(""); uint nid = pnmhdr->idfrom; if (pnmhdr->code == ttn_needtexta && (pttta->uflags & ttf_idishwnd) || pnmhdr->code == ttn_needtextw && (ptttw->uflags & ttf_idishwnd)) { // idfrom hwnd of tool nid = ::getdlgctrlid((hwnd)nid); } //m_errprojaccel[ch] contains 1 or more error messages each...
Read more

asp.net - In javascript how to find the height and width -

-
i having .aspx , masterpage page. in masterpage loading aspx page . in aspx page design using generating table structure using code-behind server in javascript how find height , width . regards, kumar if you're looking table height , width, should it var tbl = document.getelementbyid('tbldemo'); alert(tbl.offsetwidth + '\n' + tbl.offsetheight);
Read more

c# - DataTable to EnumerableRowCollection -

-
i have datatable according client requirement can contain invalid date "00/00/1999",null,empty string.(typed datset) when collect them enumerables wish convert of invalid forms empty string. (i.e) enumerablerowcollection<datarow> query = order in _table.asenumerable() select new { orderdate= string.isnullorempty(convert.tostring(order.field<datetime>("orderdate")) || (how check date invalid date) ? string.empty : order.field<datetime>("orderdate") } how check whether date valid date or not? datetime.tryparse...like given current code: datetime date; enumerablerowcollection<datarow> query = order in _table.asenumerable() select new { orderdate= string.isnullorempty(convert.tostring(order.field<datetime>("orderdate")) || !datetime.tryparse(convert.tostring(order.field<datetime...
Read more