How to prevent 'over-testing' in a test case? (C#/nUnit) -

-

i'm working on test cases @ moment, , i'm regularly finding i'm ending multiple asserts in each case. example (over-simplified , comments stripped brevity):

[test] public void testnamepropertycorrectlysetoninstantiation() {   myclass myinstance = new myclass("test name");   assert.areequal("test name", myinstance.name); }

this looks acceptable in principle, point of test verify when the class instantiated given name, name property set correctly, fails if goes wrong on instantiation, before gets assertion.

i refactored this:

[test] public void testnamepropertycorrectlysetoninstantiation() {   myclass myinstance;   string namepropertyvalue;    assert.doesnotthrow(() => myinstance = new myclass("test name"));   assert.doesnotthrow(() => namepropertyvalue = myinstance.name);   assert.areequal("test name", namepropertyvalue); }

but of course, i'm testing 3 things here; in test, i'm not interested in testing whether or not instance of myclass instantiated, or name property read successfully, these tested in case. how can test last assertion without asserting other 2 first, given it's not possible test if first 2 fail?

just have other tests check exception is thrown if initialize in invalid way. first form fine @ point, imo.

personally i'd avoid getting hung on dogma of "one assert per test". try test 1 logical path through code, fine granularity makes practical sense.


Comments

Post a Comment

Popular posts from this blog

c++ - How do I get a multi line tooltip in MFC -

-
right now, have tool tip pops when hover on edit box. problem tool tip contains multiple error messages , in 1 long line. need have each error message on own line. error messages contained in cstring new line seperating them. my existing code below. bool ontooltiptext(uint, nmhdr* pnmhdr, lresult* presult) { assert(pnmhdr->code == ttn_needtexta || pnmhdr->code == ttn_needtextw); // need handle both ansi , unicode versions of message tooltiptexta* pttta = (tooltiptexta*)pnmhdr; tooltiptextw* ptttw = (tooltiptextw*)pnmhdr; // tchar szfulltext[256]; cstring strtiptext=_t(""); uint nid = pnmhdr->idfrom; if (pnmhdr->code == ttn_needtexta && (pttta->uflags & ttf_idishwnd) || pnmhdr->code == ttn_needtextw && (ptttw->uflags & ttf_idishwnd)) { // idfrom hwnd of tool nid = ::getdlgctrlid((hwnd)nid); } //m_errprojaccel[ch] contains 1 or more error messages each...
Read more

asp.net - In javascript how to find the height and width -

-
i having .aspx , masterpage page. in masterpage loading aspx page . in aspx page design using generating table structure using code-behind server in javascript how find height , width . regards, kumar if you're looking table height , width, should it var tbl = document.getelementbyid('tbldemo'); alert(tbl.offsetwidth + '\n' + tbl.offsetheight);
Read more

c# - DataTable to EnumerableRowCollection -

-
i have datatable according client requirement can contain invalid date "00/00/1999",null,empty string.(typed datset) when collect them enumerables wish convert of invalid forms empty string. (i.e) enumerablerowcollection<datarow> query = order in _table.asenumerable() select new { orderdate= string.isnullorempty(convert.tostring(order.field<datetime>("orderdate")) || (how check date invalid date) ? string.empty : order.field<datetime>("orderdate") } how check whether date valid date or not? datetime.tryparse...like given current code: datetime date; enumerablerowcollection<datarow> query = order in _table.asenumerable() select new { orderdate= string.isnullorempty(convert.tostring(order.field<datetime>("orderdate")) || !datetime.tryparse(convert.tostring(order.field<datetime...
Read more